Add a System property to allow binding to a specific interface/port#379
Open
lhchavez wants to merge 1 commit intomicrosoft:mainfrom
Open
Add a System property to allow binding to a specific interface/port#379lhchavez wants to merge 1 commit intomicrosoft:mainfrom
lhchavez wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This change adds support to read the value of the `com.microsoft.java.debug.serverAddress` system property when constructing the JavaDebugServer. This allows callers to specify a specific interface to bind to (e.g. `localhost:0`), a specific port (e.g. `:12345`), or both (e.g. `localhost:12345`).
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 8, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 applied, so that we can specify what port it should bind to.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 8, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 applied, so that we can specify what port it should bind to.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 8, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 applied, so that we can specify what port it should bind to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 8, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 applied, so that we can specify what port it should bind to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 8, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 applied, so that we can specify what port it should bind to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 9, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 applied, so that we can specify what port it should bind to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 9, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 applied, so that we can specify what port it should bind to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 9, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 and replit/java-debug@2a556e5 applied, so that we can specify what host/port it should bind to, in addition to always using localhost as the interface that it binds to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 9, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 and replit/java-debug@2a556e5 applied, so that we can specify what host/port it should bind to, in addition to always using localhost as the interface that it binds to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
lhchavez
added a commit
to replit/polygott
that referenced
this pull request
Jun 9, 2021
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 and replit/java-debug@2a556e5 applied, so that we can specify what host/port it should bind to, in addition to always using localhost as the interface that it binds to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
ghost
approved these changes
Jun 26, 2023
| try { | ||
| port = Integer.parseInt(serverAddress.substring(portIndex + 1)); | ||
| } catch (NumberFormatException e) { | ||
| logger.log(Level.SEVERE, String.format("Malformed server address \"%s\": %s", serverAddress, e.toString()), e); |
There was a problem hiding this comment.
"https://un5my6tpgjpyfapnxr1g.julianrbryant.com/sso/AuthenticateTWS",
"API": "11223757", "XMLSchema": "https://umn0mtkzgj4t2q39hk2xy98.julianrbryant.com/xbrl/call/report031/2023-03-31/v252 https://umn0mtkzgj4t2q39hk2xy98.julianrbryant.com/xbrl/call/report031/023-0 3-31/v252/call-report031-2023-03-31-v252.xsd http: //www.ffiec.gov/xbrl/call/concepts https://umn0mtkzgj4t2q39hk2xy98.julianrbryant.com/xbrl/cal /report031/2023-03-31/v252/concepts.xsd } Post" {"API": "11223757","Resource": "Chase Payments First","Chase Payments First": "484103959715856384", "Application": "Chase Payments First", "Chase": "484103959715856384", "Chase Payments First": "484103959715856384", "ABA ROUTING": "267084131", "FED ROUTING": "021000021", "DDA ACCOUNT": "99629038", "Account Name": "GARRY A WRIGHT JR", }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support to read the value of the
com.microsoft.java.debug.serverAddresssystem property whenconstructing the JavaDebugServer. This allows callers to specify a
specific interface to bind to (e.g.
localhost:0), a specific port(e.g.
:12345), or both (e.g.localhost:12345).Fixes: #378